Fix runs beforeAll/afterAll in excluded suites (#4820)

[jbdemonte]

Disable run of beforeAll when test suite is desactivated

Summary

Test plan

describe('ROOT', () => {
  describe('SUB_1', () => {
    beforeAll(() => {
      console.log('SUB_1: beforeAll')
    });
    it('test 1', () => {
      console.log('SUB_1: test 1');
    });
  });

  describe('SUB_2', () => {
    beforeAll(() => {
      console.log('SUB_2: beforeAll')
    });
    it('test 2', () => {
      console.log('SUB_2: test 2');
    });
  });
});

run using jest test.js --testNamePattern="test 1"

Logs before the modification:

 PASS  ./test.js
  ROOT
    SUB_1
      ✓ test 1 (1ms)
    SUB_2
      ○ skipped 1 test

  console.log test.js:4
    SUB_1: beforeAll

  console.log test.js:7
    SUB_1: test 1

  console.log test.js:14
    SUB_2: beforeAll

Logs after the modification:

 PASS  ./test.js
  ROOT
    SUB_1
      ✓ test 1 (1ms)

  console.log test.js:4
    SUB_1: beforeAll

  console.log test.js:7
    SUB_1: test 1

[SimenB]

This is awesome, thanks for tackling it!

Mind adding an integration test?

[SimenB]

should point to the PR, not the issue 🙂

[jbdemonte]

I wanted to add an integration test, but I didn't find how to, and I had no time to dig how those tests worked, I'll try to take the time by the end of the week

[jbdemonte]

@SimenB Sorry, but I really have no idea of where / how to test it, right now, I still have not undestood how tests works in jest :(

[SimenB]

All the directories in https://github.com/facebook/jest/tree/master/e2e are integration tests. They each have a corresponding test in https://github.com/facebook/jest/tree/master/e2e/__tests__ which spawns up a jest instance.

You can look at e.g, https://github.com/facebook/jest/tree/master/e2e/before-each-queue for an example of a test with hooks and assertions on the output.

---

@rickhanlonii any progress on that contributing guide? :)

[jbdemonte]

arf, I was trying to play in the folder /Users/jbd/git/reboot/jest/packages/jest-jasmine2/src/__tests__

[jbdemonte]

I'm confused, it seems to work on my machine (as usual) but fails on the CI

[SimenB]

We're in the process of replacing jasmine as the underlying runner with jest-circus (#6295).

If you run JEST_CIRCUS=1 ./jest before-all-filtered.js you should see the failure locally as well 🙂

[codecov-io]

Codecov Report

Merging #6234 into master will decrease coverage by 0.07%.
The diff coverage is 5.55%.

@@            Coverage Diff             @@
##           master    #6234      +/-   ##
==========================================
- Coverage   63.89%   63.81%   -0.08%     
==========================================
  Files         228      228              
  Lines        8705     8717      +12     
  Branches        4        4              
==========================================
+ Hits         5562     5563       +1     
- Misses       3142     3153      +11     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-jasmine2/src/tree_processor.js	0% <0%> (ø)	⬆️
packages/jest-circus/src/utils.js	21.18% <9.09%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c91d5...996e2a9. Read the comment docs.

[jbdemonte]

I had no clue there were two different runner :)

[thymikee]

It's quite fresh, don't tell anyone 😉

[SimenB]

@aaronabramov mind taking a quick look at the circus implementation?

[jbdemonte]

just rebased

[aaronabramov]

wait.. it should already work in jest-circus! i remember i worked on it last year! :)

[aaronabramov]

ah yeah.. i see! we do still run hooks even if it's skipped.
that fix looks great!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.