Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set cwd in babel-jest #7574

Merged
merged 2 commits into from Jan 4, 2019
Merged

fix: set cwd in babel-jest #7574

merged 2 commits into from Jan 4, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 4, 2019

Summary

Fixes #7438. See that for motivation

Test plan

Test added

@SimenB SimenB mentioned this pull request Jan 4, 2019
Closed
SimenB
SimenB commented Jan 4, 2019
View reviewed changes
packages/babel-jest/src/index.js
@@ -35,16 +41,6 @@ export const createTransformer = (options: any): Transformer => {
delete options.cacheDirectory;
delete options.filename;

const loadBabelOptions = filename =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no real reason for this extra function

SimenB
SimenB commented Jan 4, 2019
View reviewed changes
e2e/transform/babel-jest/__tests__/changed_cwd.test.js
@@ -0,0 +1,22 @@
/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test fails without the change in babel-jest, but it only failed due to the other files in this project having flow code in them. Should we have a more explicit test? Not sure how, though, so ideas welcome

@codecov-io
Copy link

Codecov Report

Merging #7574 into master will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7574   +/-   ##
=======================================
  Coverage   67.99%   67.99%           
=======================================
  Files         248      248           
  Lines        9490     9490           
  Branches        6        5    -1     
=======================================
  Hits         6453     6453           
  Misses       3035     3035           
  Partials        2        2
Impacted Files Coverage Δ
packages/babel-jest/src/index.js 72.22% <80%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103f068...8968ead. Read the comment docs.

thymikee
thymikee approved these changes Jan 4, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test tells enough

@SimenB SimenB merged commit e8b3d59 into jestjs:master Jan 4, 2019
@SimenB SimenB deleted the cwd-babel branch January 7, 2019 11:02
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@SimenB @captain-yossarian
fix: set cwd in babel-jest (jestjs#7574)
e191f15
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

babel 7 with dynamic requires does not work
4 participants
@SimenB @codecov-io @thymikee @facebook-github-bot