New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate expect to typescript #7919
Merged
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
3e04c16
Rename src files
natealcedo 43320f3
Migrate utils.ts
natealcedo bf35c81
Add tsconfig
natealcedo 110729b
Add jest-types reference
natealcedo 6ce71f6
Implement types.ts for expect
natealcedo fc978a6
Add a types key in package.json
natealcedo 221074c
Migrate toThrowMatchers
natealcedo 1cd1006
Migrate spyMatchers
natealcedo 9e0d8e6
Migrate matchers
natealcedo ab7d1e1
Migrate jasmineUtils
natealcedo 73042ba
migrate fakechalk
natealcedo 30efca3
Migrate extractExpectedAssertionsErrors
natealcedo 032c6ee
Migrate asymmetricMatchers
natealcedo f4f5536
Migrate jestMatchersObject
natealcedo bf8198c
Upate Expectation object definition
natealcedo a62f3a4
Migrate expect/index.ts
natealcedo 428620d
Add a diff file since it wont fit in the PR description
natealcedo 1d9fe02
Run eslint
natealcedo feb8e86
Declare jest types as a depenency
natealcedo b221710
import type localy
natealcedo 4258222
Sort dependencies in package.json
natealcedo 2801634
Change returnInput argument type
natealcedo 88cb209
Type syncResult and asyncResult
natealcedo 8ab2dae
Remove MatcherHintOptions in types.ts
natealcedo 59ab17d
Type this in matchers to use MatcherState and options to use MatcherH…
natealcedo a3e1d44
Remove flow declaration
natealcedo a48b31f
Better type asmmetricMathchers
natealcedo 27b2049
Export Tester type
natealcedo 282b15e
Improve types for jasmineUtils
natealcedo 2d41e89
Improve types for jestMatchersObject
natealcedo dddf3d2
Improve typings for matchers
natealcedo d99c26c
Improve spyMatchers typings
natealcedo 7f5575d
Improve types for toThrowMatchers
natealcedo a8ff374
Improve types for utils.ts
natealcedo 7f2aef4
Update diff file
natealcedo 602e34c
Add a typeguard for jasmineUtils
natealcedo bf61f89
Update createToThrowErrorMatchingSnapshotMatcher typing
natealcedo 4ede592
Type getMessage and isPromise
natealcedo 72feb3e
Type case matcher call
natealcedo bf24385
tweak
SimenB db1389d
remove diff file
SimenB 90dffa8
tweak promise type guard
SimenB cc42c7c
revert ignorefile change
SimenB 8fef3e4
prettier on jasmine utils
SimenB fbb94e3
fix copyright header
SimenB a432bb5
Merge branch 'master' into migrate/expect
SimenB b51b16a
update changelog
SimenB e14c798
small type adjustments; use jestMatcherUtils for MatcherState
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
// TODO: Move this to `expect` when it's migrated | ||
// TODO: Remove this when whole project is migrated | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cannot do it currently, because of |
||
|
||
import {Path} from './Config'; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just copying over from the original code. This typing seems more accurate than my previous change. comments are appreciated