Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for existence of Element when comparing DOM-nody-things (#7786) (clean cherry pick version) #7995

Merged
merged 8 commits into from Mar 1, 2019
Merged

Check for existence of Element when comparing DOM-nody-things (#7786) (clean cherry pick version) #7995

merged 8 commits into from Mar 1, 2019

Commits on Feb 26, 2019

  1. Check for existence of Element when comparing DOM-nody-things (#7786)

    @mfeineis
    mfeineis committed Feb 26, 2019
    Copy the full SHA
    c22ec2d View commit details
    Browse the repository at this point in the history

  2. Fall back to deep equality for presumed DOM nodes if Element is not… 

    … in scope (#7786)
    @mfeineis
    mfeineis committed Feb 26, 2019
    Copy the full SHA
    50da3fc View commit details
    Browse the repository at this point in the history

  3. Remove IE<9 specific fallback DOM node comparison (#7786)

    @mfeineis
    mfeineis committed Feb 26, 2019
    Copy the full SHA
    f47ae58 View commit details
    Browse the repository at this point in the history

  4. Check for global DOM Node in isDomNode (#7786) 

    In a real browser and JSDOM the check will use DOM-Level-3 `Node.isEqualNode`
and for everything else a deep equality check should do the trick.
    @mfeineis
    mfeineis committed Feb 26, 2019
    Copy the full SHA
    8f3265b View commit details
    Browse the repository at this point in the history

  5. Check that isEqualNode is a function and remove duck typing from `i… 

    …sDomNode` (#7786)
    @mfeineis
    mfeineis committed Feb 26, 2019
    Copy the full SHA
    aabb662 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Add changelog entry for streamlined DOM node comparisons in expect (#… 

    …7786)
    @mfeineis
    mfeineis committed Mar 1, 2019
    Copy the full SHA
    44309ee View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into expect-dom-nodeenv-bug-7786-clean

    @mfeineis
    mfeineis committed Mar 1, 2019
    Copy the full SHA
    0fe182c View commit details
    Browse the repository at this point in the history

  3. Correct visible PR number in CHANGELOG.md

    @pedrottimark
    pedrottimark committed Mar 1, 2019
    Copy the full SHA
    79e152d View commit details
    Browse the repository at this point in the history