Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change method of obtaining git root (#3214) #8052

Merged
merged 9 commits into from Mar 19, 2019
Merged

Change method of obtaining git root (#3214) #8052

merged 9 commits into from Mar 19, 2019

Commits on Mar 5, 2019

  1. Change method of obtaining git root (#3214) 

    On various environments like cygwin path returned by --show-toplevel is cygwin path, not windows path.
Instead of that --show-cdup can be used and merged with root of npm project giving root of git repo
    @bwiercinski
    bwiercinski committed Mar 5, 2019
    Copy the full SHA
    382e627 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @bwiercinski
    bwiercinski committed Mar 5, 2019
    Copy the full SHA
    3666f32 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Fix tests for #8052 

    For execa it does not matter if path is ended with folder separator
    @bwiercinski
    bwiercinski committed Mar 6, 2019
    Copy the full SHA
    f864f7f View commit details
    Browse the repository at this point in the history

  2. Change method of defining path of npm root 

    Instead of absolute path, use path relative to git root.
Thanks to that it works on various windows enviroments etc. Cygwin which
requires cygwin path if absolute
    @bwiercinski
    bwiercinski committed Mar 6, 2019
    Copy the full SHA
    eb0829d View commit details
    Browse the repository at this point in the history

  3. Normalize path to avoid empty string as path 

    for case path.relative(dir, dir) returning ''
    @bwiercinski
    bwiercinski committed Mar 6, 2019
    Copy the full SHA
    d155af2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into patch-1

    @bwiercinski
    bwiercinski committed Mar 6, 2019
    Copy the full SHA
    f36ef23 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Use resolve when obtaining absolute path of git's root directory 

    Co-Authored-By: bwiercinski <bmwbartek1@gmail.com>
    @SimenB @bwiercinski
    SimenB and bwiercinski committed Mar 7, 2019
    Copy the full SHA
    9663428 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Merge branch 'master' into patch-1

    @SimenB
    SimenB committed Mar 19, 2019
    Copy the full SHA
    b6560e0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into patch-1

    @SimenB
    SimenB committed Mar 19, 2019
    Copy the full SHA
    2954285 View commit details
    Browse the repository at this point in the history