Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monorepo-internal peer dependencies (temporarily) #8215

Merged
merged 7 commits into from Mar 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Expand Up @@ -23,6 +23,9 @@
- `[@jest/reporters]` Fix Cannot read property converageData of null ([#8168](https://github.com/facebook/jest/pull/8168))
- `[jest-worker]` `JEST_WORKER_ID` starts at 1 ([#8205](https://github.com/facebook/jest/pull/8205))
- `[jest-config]` Use default cwd even if config contains a cwd property ([#7923](https://github.com/facebook/jest/pull/7923))
- `[jest-resolve-dependencies]`: Remove internal peer dependencies ([#8215](https://github.com/facebook/jest/pull/8215))
- `[jest-resolve]`: Remove internal peer dependencies ([#8215](https://github.com/facebook/jest/pull/8215))
- `[jest-snapshot]`: Remove internal peer dependencies ([#8215](https://github.com/facebook/jest/pull/8215))

### Chore & Maintenance

Expand Down
4 changes: 0 additions & 4 deletions packages/jest-resolve-dependencies/package.json
Expand Up @@ -19,10 +19,6 @@
"jest-resolve": "^24.5.0",
"jest-runtime": "^24.5.0"
},
"peerDependencies": {
"jest-haste-map": "^24.0.0",
"jest-resolve": "^24.1.0"
},
"engines": {
"node": ">= 6"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/jest-resolve-dependencies/src/index.ts
Expand Up @@ -6,8 +6,8 @@
*/

import {Config} from '@jest/types';
import {FS as HasteFS} from 'jest-haste-map';
import Resolver from 'jest-resolve';
import {FS as HasteFS} from 'jest-haste-map'; // eslint-disable-line import/no-extraneous-dependencies
import Resolver from 'jest-resolve'; // eslint-disable-line import/no-extraneous-dependencies
import {isSnapshotPath, SnapshotResolver} from 'jest-snapshot';

namespace DependencyResolver {
Expand Down
3 changes: 0 additions & 3 deletions packages/jest-resolve/package.json
Expand Up @@ -20,9 +20,6 @@
"@types/browser-resolve": "^0.0.5",
"jest-haste-map": "^24.5.0"
},
"peerDependencies": {
"jest-haste-map": "^24.0.0"
},
"engines": {
"node": ">= 6"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-resolve/src/index.ts
Expand Up @@ -7,7 +7,7 @@

import path from 'path';
import {Config} from '@jest/types';
import {ModuleMap} from 'jest-haste-map';
import {ModuleMap} from 'jest-haste-map'; // eslint-disable-line import/no-extraneous-dependencies
import {sync as realpath} from 'realpath-native';
import chalk from 'chalk';
import nodeModulesPaths from './nodeModulesPaths';
Expand Down
3 changes: 0 additions & 3 deletions packages/jest-snapshot/package.json
Expand Up @@ -23,9 +23,6 @@
"pretty-format": "^24.5.0",
"semver": "^5.5.0"
},
"peerDependencies": {
"jest-haste-map": "^24.0.0"
},
"devDependencies": {
"@types/mkdirp": "^0.5.2",
"@types/natural-compare": "^1.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-snapshot/src/index.ts
Expand Up @@ -7,7 +7,7 @@

import fs from 'fs';
import {Config} from '@jest/types';
import {FS as HasteFS} from 'jest-haste-map';
import {FS as HasteFS} from 'jest-haste-map'; // eslint-disable-line import/no-extraneous-dependencies
import {MatcherState} from 'expect';

import diff from 'jest-diff';
Expand Down