Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(watchPlugins): fix argument passed to shouldRunTestSuite #8240

Closed
wants to merge 1 commit into from

Conversation

posva
Copy link
Contributor

@posva posva commented Mar 29, 2019

Summary

I found the testPath was a property of an object and not the direct argument so I updated the doc to use testSuite as that's what it looked to me but there is probably a better wording

Test plan

N/A

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #8240 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8240   +/-   ##
=======================================
  Coverage   62.33%   62.33%           
=======================================
  Files         265      265           
  Lines       10553    10553           
  Branches     2565     2565           
=======================================
  Hits         6578     6578           
  Misses       3387     3387           
  Partials      588      588

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08be02...ab2050a. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry about the slow review!

Could you update the versioned docs as well?

image

@posva
Copy link
Contributor Author

posva commented Nov 12, 2019

Well, turns out it's was merged on a more recent PR (#8784)

@posva posva closed this Nov 12, 2019
@posva posva deleted the patch-1 branch November 12, 2019 16:29
@SimenB
Copy link
Member

SimenB commented Nov 12, 2019

Ah, sorry about that

@posva
Copy link
Contributor Author

posva commented Nov 12, 2019 via email

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants