Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules, vulnerability error #8263

Closed
wants to merge 1 commit into from
Closed

Conversation

odykyi
Copy link

@odykyi odykyi commented Apr 3, 2019

Update modules, vulnerability error when check dependencies

Xray scan found vulnerability error in handlebars lib

https://jfrog.com/integration/npm-xray/

Update modules, vulnerability error when check dependencies Xray scan found vulnerability error in `handlebars` lib https://jfrog.com/integration/npm-xray/
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@odykyi
Copy link
Author

odykyi commented Apr 3, 2019

@scotthovestadt review please

thanks!

@thymikee
Copy link
Collaborator

thymikee commented Apr 3, 2019

You'll need to update the lock file as well.

@SimenB
Copy link
Member

SimenB commented Apr 3, 2019

And sign the CLA

@SimenB
Copy link
Member

SimenB commented Apr 3, 2019

Note that the change in this PR will never be visible outside of this repo, so it's not really an issue at all, the published modules were fixed a couple of months ago by #7904, released in 24.3.0

@odykyi
Copy link
Author

odykyi commented Apr 3, 2019

You'll need to update the lock file as well.

I checked

yarn.lock the same

not need to update

@chadlavi-casebook
Copy link

What's the status on this? The latest version of jest still has this vulnerability.

@SimenB
Copy link
Member

SimenB commented Jul 5, 2019

which vulnerabilities? Again, this PR changes nothing for the published version of Jest

@chadlavi-casebook
Copy link

which vulnerabilities? Again, this PR changes nothing for the published version of Jest

I found this issue because I got an automated alert from github that handlebars 4.1.1 had a security vulnerability. When I did a yarn why handlebars (I don't use handlebars), I found that it's a dependency of jest. I'm on the latest version of jest, and still finding that the same version of handlebars is installed by it.

@SimenB
Copy link
Member

SimenB commented Jul 5, 2019

Just upgrade it then. Easiest is probably to delete the whole handlebars entry in your lockfile, and re-run yarn. yarnpkg/yarn#4986 would have made it easier

@SimenB SimenB closed this in 12880f5 Jul 5, 2019
@SimenB
Copy link
Member

SimenB commented Jul 5, 2019

With ^ I bumped the version in the published package from Jest. That won't be get a release anytime soon though, so your better of running npm audit --fix or manually upgrade the dependency for yarn (yarnpkg/yarn#7075)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants