Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-resolve - wrap realpath with try catch block #8292

Closed
wants to merge 3 commits into from
Closed

jest-resolve - wrap realpath with try catch block #8292

wants to merge 3 commits into from

Conversation

aliaksandr-yermalayeu
Copy link

@aliaksandr-yermalayeu aliaksandr-yermalayeu commented Apr 9, 2019

Summary

Fixes #8291

Test plan

Minor changes in snapshots

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #8292 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8292      +/-   ##
==========================================
+ Coverage   63.85%   63.85%   +<.01%     
==========================================
  Files         274      274              
  Lines       11389    11390       +1     
  Branches     2771     2770       -1     
==========================================
+ Hits         7272     7273       +1     
  Misses       3498     3498              
  Partials      619      619
Impacted Files Coverage Δ
packages/jest-resolve/src/index.ts 44.6% <50%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf90c0...c2a3406. Read the comment docs.

@thymikee thymikee requested a review from SimenB July 10, 2019 07:49
@thymikee
Copy link
Collaborator

Looks like the snapshots are still off, could you rebase it once again to the latest master?

@aliaksandr-yermalayeu
Copy link
Author

@thymikee, I updated snapshots, could please take one more look? One check which is failing seems not related to my changes.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a changelog entry?

@aliaksandr-yermalayeu
Copy link
Author

@thymikee, updated changelog, does it looks correct?

@aliaksandr-yermalayeu
Copy link
Author

@thymikee, thanks for review!

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if I understand @SimenB's comment in #8291 correctly, the preferred solution would be to only change it in SimenB/realpath-native#39?

@aliaksandr-yermalayeu
Copy link
Author

Correct, but the problem is that the owners of realpath may not be really interested in this change. Three months have passed, but it doesn't seem to be getting anywhere.

Here is another possible solution that may probably work in this case:
#8530

@thymikee
Copy link
Collaborator

thymikee commented May 2, 2020

@SimenB rebased, this should be good to review again

@SimenB
Copy link
Member

SimenB commented May 2, 2020

@thymikee #9952

@thymikee
Copy link
Collaborator

thymikee commented May 2, 2020

Can we close this then?

@SimenB
Copy link
Member

SimenB commented May 2, 2020

Should be fixed with the above linked PR

@SimenB SimenB closed this May 2, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-resolve throws on network drives
6 participants