Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: db.close no longer necessary #8333

Merged
merged 4 commits into from Feb 24, 2022
Merged

docs: db.close no longer necessary #8333

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f359d63
new version of mongodb-memory-server
rick-shar-ww Apr 15, 2019
1db949c
Merge branch 'main' into db-close-docs
SimenB Feb 24, 2022
f5bc1f2
remove from all versioned docs
SimenB Feb 24, 2022
abbcaed
ws
SimenB Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/MongoDB.md
View file
Open in desktop
Expand Up @@ -115,7 +115,6 @@ beforeAll(async () => {

afterAll(async () => {
await connection.close();
await db.close();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep a comment around saying if you're on version x, you need to call close as well

});

it('should aggregate docs from collection', async () => {
Expand Down