Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set MODULE_NOT_FOUND code when module is not resolved from paths #8487

Merged
merged 13 commits into from Nov 9, 2019
Merged

fix: set MODULE_NOT_FOUND code when module is not resolved from paths #8487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ee3f826
fix: set MODULE_NOT_FOUND code when module is not resolved from paths
clarkdo May 23, 2019
720bcd3
add ModuleNotFound error and test
clarkdo May 24, 2019
6e0c6a0
fix test
clarkdo May 24, 2019
9c53c03
update snapshot
clarkdo May 24, 2019
149d11a
update snapshot
clarkdo May 24, 2019
971eb0d
separate throw and new
clarkdo May 24, 2019
3a42989
code review changes
clarkdo May 24, 2019
247bad7
add test for require
clarkdo May 24, 2019
e9269ef
add changelog
clarkdo May 24, 2019
12e2645
createModuleNotFoundError
clarkdo May 28, 2019
a9cb6f8
add static ModuleNotFoundError
clarkdo May 28, 2019
4914b21
update snapshot
clarkdo May 28, 2019
4b6fd61
Merge branch 'master' into fix/reesolve-paths-err-code
SimenB Nov 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/jest-resolve/src/index.ts
View file
Open in desktop
Expand Up @@ -103,10 +103,6 @@ class Resolver {
return null;
}

static createModuleNotFoundError(message?: string) {
return new ModuleNotFoundError(message);
}

resolveModuleFromDirIfExists(
dirname: Config.Path,
moduleName: string,
Expand Down Expand Up @@ -438,4 +434,5 @@ Please check your configuration for these entries:
return error;
};

export = Resolver;
export {ModuleNotFoundError};
export default Resolver;
thymikee marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions packages/jest-runtime/src/index.ts
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ import {SourceMapRegistry} from '@jest/source-map';
import jestMock, {MockFunctionMetadata} from 'jest-mock';
import HasteMap, {ModuleMap} from 'jest-haste-map';
import {formatStackTrace, separateMessageFromStack} from 'jest-message-util';
import Resolver from 'jest-resolve';
import Resolver, {ModuleNotFoundError} from 'jest-resolve';
import {createDirectory, deepCyclicCopy} from 'jest-util';
import {escapePathForRegex} from 'jest-regex-util';
import Snapshot from 'jest-snapshot';
Expand Down Expand Up @@ -647,7 +647,7 @@ class Runtime {
return module;
}
}
const err = Resolver.createModuleNotFoundError(
const err = new ModuleNotFoundError(
`Cannot resolve module '${moduleName}' from paths ['${paths.join(
"', '",
)}'] from ${from}`,
Expand Down