chore: upgrade to eslint@6 #8855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #8855 +/- ##
=====================================
Coverage 63.8% 63.8%
=====================================
Files 274 274
Lines 11576 11576
Branches 2841 2842 +1
=====================================
Hits 7386 7386
Misses 3560 3560
Partials 630 630
Continue to review full report at Codecov.
|
thymikee
approved these changes
Aug 20, 2019
SimenB
added a commit
that referenced
this pull request
Aug 21, 2019
SimenB
added a commit
that referenced
this pull request
Aug 22, 2019
SimenB
added a commit
that referenced
this pull request
Aug 22, 2019
|
@SimenB seems like babel-eslint issue is resolved? https://twitter.com/left_pad/status/1165738603755925504 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems to have some weird lint errors, so a separate PR seems like a good idea.
fileis definetely used, not sure what's upEDIT: Seems to be a bug in babel-eslint
babel/babel-eslint#791
eslint/eslint#12117
I've locked it at 6.1 which works fine
Test plan
Green CI