chore: upgrade chalk to v3 #9154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedrottimark @thymikee could you verify that the snapshot changes in the last commit are sane? |
|
@SimenB Thank you very much! The chalk release comes at a great time for Jest. Yes, the snapshot changes seem sane as far as this upgrade PR is concerned. Reading the dense or duplicate codes suggests some clean-up chores in those parts of Jest. After you merge this pull request, then I will want to merge the changes into #9132 |
thymikee
approved these changes
Nov 9, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's new and thus better.
https://github.com/chalk/chalk/releases/tag/v3.0.0
Test plan
Green CI