Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken transform link on webpack page #9155

Merged
merged 2 commits into from Nov 9, 2019
Merged

docs: Fix broken transform link on webpack page #9155

merged 2 commits into from Nov 9, 2019

Conversation

laranhee
Copy link
Contributor

@laranhee laranhee commented Nov 9, 2019

Summary

transform link on Using with webpack (https://jestjs.io/docs/en/webpack) is broken. So, it does not lead to configuration's transform section (https://jestjs.io/docs/en/configuration#transform-object-string-pathtotransformer-pathtotransformer-object).

Test plan

@@ -0,0 +1,234 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this file as it should use the one in docs.

However, can you verify the other versioned docs are linked correctly? https://jestjs.io/en/versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check other versioned docs (Past Versions) are linked correctly. (/configuration#transform-object-string-string)

And, I checked that link is broken in Current(24.9) and Latest version.
Because Configuration page's transform fragment was changed since #7288
(/configuration#transform-object-string-pathtotransformer-pathtotransformer-object)

In development, I added this file to fix broken link in Current version(24.9).

Did I miss something or misunderstand in development and your feedback?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it seems you've done it entirely correct. Thank you!

@codecov-io
Copy link

codecov-io commented Nov 9, 2019

Codecov Report

Merging #9155 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9155      +/-   ##
==========================================
- Coverage   64.82%   64.77%   -0.05%     
==========================================
  Files         277      277              
  Lines       11734    11722      -12     
  Branches     2882     2877       -5     
==========================================
- Hits         7606     7593      -13     
- Misses       3511     3512       +1     
  Partials      617      617
Impacted Files Coverage Δ
packages/jest-diff/src/diffLines.ts 95.23% <0%> (-4.77%) ⬇️
packages/jest-transform/src/ScriptTransformer.ts 68.91% <0%> (-0.42%) ⬇️
packages/jest-diff/src/printDiffs.ts 100% <0%> (ø) ⬆️
packages/jest-core/src/watch.ts 78.53% <0%> (ø) ⬆️
...s/jest-core/src/lib/handle_deprecation_warnings.ts 0% <0%> (ø) ⬆️
packages/jest-core/src/runJest.ts 56% <0%> (ø) ⬆️
packages/pretty-format/src/plugins/DOMElement.ts 96.42% <0%> (ø) ⬆️
packages/jest-snapshot/src/printSnapshot.ts 100% <0%> (ø) ⬆️
packages/jest-core/src/FailedTestsCache.ts 76.47% <0%> (ø) ⬆️
packages/jest-message-util/src/index.ts 68.34% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5bac1...2b461e2. Read the comment docs.

@SimenB SimenB merged commit 56460f6 into jestjs:master Nov 9, 2019
@laranhee laranhee deleted the patch-1 branch November 9, 2019 16:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants