Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): enable eslint-comments/no-unused-disable #9241

Merged
merged 2 commits into from Nov 30, 2019
Merged

chore(lint): enable eslint-comments/no-unused-disable #9241

merged 2 commits into from Nov 30, 2019

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 29, 2019

Summary

@SimenB remember this one isn't enabled by the recommended. I've done this via github, so will see what fails in the CI and then maybe fix 馃し鈥嶁檪

Test plan

Run the CI, and see what fails.

@G-Rath
Copy link
Contributor Author

G-Rath commented Nov 29, 2019

@SimenB eslint-plugin-jest needs to be updated for this to pass CI, as I just merged jest-community/eslint-plugin-jest#430 which makes no-focused-tests check focused tests using .each with table format (which is what the CI is failing on, as right now it's an unneeded eslint-disable).

@SimenB
Copy link
Member

SimenB commented Nov 29, 2019

Please bump the eslint plugin as well 馃檪

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 8ddadfc into jestjs:master Nov 30, 2019
@G-Rath G-Rath deleted the patch-1 branch November 30, 2019 23:59
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants