Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: give recommendation on jest-worker end() Promises #9310

Merged
merged 4 commits into from
Dec 15, 2019
Merged

docs: give recommendation on jest-worker end() Promises #9310

merged 4 commits into from
Dec 15, 2019

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Dec 15, 2019 •
edited

thymikee
thymikee approved these changes Dec 15, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to mention that

packages/jest-worker/README.md Outdated Show resolved Hide resolved
packages/jest-worker/README.md Outdated Show resolved Hide resolved
@jeysal jeysal mentioned this pull request Dec 15, 2019
Merged
jeysal and others added 3 commits December 15, 2019 21:26
@jeysal @thymikee
Update packages/jest-worker/README.md
8283fb0 
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
@jeysal @thymikee
Update packages/jest-worker/README.md
0248bfc 
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
@jeysal
Update README.md
79b2b3a
@jeysal jeysal merged commit 72a1447 into jestjs:master Dec 15, 2019
@jeysal jeysal deleted the jest-worker-end-promise-doc branch December 15, 2019 21:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

@SimenB SimenB Awaiting requested review from SimenB

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeysal @thymikee @facebook-github-bot