fix: use default maxCols from Istanbul #9442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Jan 22, 2020
SimenB
force-pushed
the
coverage-max-cols
branch
from
1cd5aa0
to
21fe56f
Compare
|
@SimenB I on board with using the full available space (which is the default, right?). Do you plan to finish it? We may still need to set it when testing though |
|
Should probably land this, yeah... I'll rebase now and we can see where we're at |
SimenB
force-pushed
the
coverage-max-cols
branch
from
a1438d3
to
d63f53a
Compare
SimenB
force-pushed
the
coverage-max-cols
branch
from
d63f53a
to
5514006
Compare
SimenB
force-pushed
the
coverage-max-cols
branch
from
5514006
to
f847e8a
Compare
|
Abbreviated filenames are IMO strictly worse, so let's abandon this |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9441.
Test plan
CI will fail, I just wanna see how it looks