Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fsync: false when writing cache files #9695

Merged
merged 1 commit into from Mar 24, 2020
Merged

fix: fsync: false when writing cache files #9695

merged 1 commit into from Mar 24, 2020

Commits on Mar 24, 2020

  1. fix: fsync: false when writing cache files 

    We're using writeFileAtomic here in order to get atomic rename, not
to get full system power failure resilience. Most(tm) filesystems
will guarantee either/or during a crash here, which is plenty
enough for us.

fsync is a nearly 3x slowdown for me, ts-jest'ing my whole codebase
(~900 files in testcase).
    @FauxFaux
    FauxFaux committed Mar 24, 2020
    Copy the full SHA
    4ef8aa7 View commit details
    Browse the repository at this point in the history