Pretty print labels #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jesusvasquez333
requested changes
Jan 14, 2024
| @@ -238,9 +238,10 @@ def get_env_var(env_var_name, echo_value=False): | |||
| if review_missing_label: | |||
| print('The last review already requested changes') | |||
| else: | |||
| formatted_labels = "\n".join(map(lambda label: f"• {label}", valid_labels)) | |||
There was a problem hiding this comment.
Thank you for the suggestion @JakeCooper. Although I don't think the code as-is will have the intended result. The message looks like this:
Instead, I think you want the code to be:
formatted_labels = "\n".join(f"* `{label}`" for label in valid_labels)
pr.create_review(
body='This pull request does not contain a valid label.\n\nPlease '
f'add one of the following labels:\n{formatted_labels}',
event='REQUEST_CHANGES')
(also, the map and lambda are not really needed, the simplified code above will produce the same result).
With this change the message looks like this (which I think if what you wanted?):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awesome action. Thoughts on a lil bit o pretty printing of the labels?