Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic client for registries #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tfadeyi
Copy link

@tfadeyi tfadeyi commented Nov 20, 2020

This adds a generic client that uses the docker api instead of specific
client libraries. Other clients should wrap it to make use of the dockerapi.

Signed-off-by: oluwole.fadeyi oluwole.fadeyi@jetstack.io

This adds a generic client that uses the docker api instead of specific
client libraries.
Other clients should wrap it to make use of the dockerapi.

Signed-off-by: oluwole.fadeyi <oluwole.fadeyi@jetstack.io>
@jetstack-bot
Copy link
Contributor

@tfadeyi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tfadeyi
To complete the pull request process, please assign joshvanl
You can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot
Copy link
Contributor

@tfadeyi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-version-checker-verify 2a79d03 link /test pull-version-checker-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot
Copy link
Contributor

@tfadeyi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants