do not throw from a method that is called from a callback

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
jetty · May 2, 2024 · c6f0fb6 · c6f0fb6
1 parent d6ccfa8
commit c6f0fb6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/.../jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannelState.java b/.../jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannelState.java
@@ -28,6 +28,7 @@
 import org.eclipse.jetty.server.Request;
 import org.eclipse.jetty.server.Response;
 import org.eclipse.jetty.server.handler.ErrorHandler;
+import org.eclipse.jetty.util.ExceptionUtil;
 import org.eclipse.jetty.util.thread.AutoLock;
 import org.eclipse.jetty.util.thread.Scheduler;
 import org.slf4j.Logger;
@@ -1059,7 +1060,7 @@ protected void completed(Throwable failure)
                 LOG.debug("completed {}", toStringLocked());
 
             if (_requestState != RequestState.COMPLETING)
-                throw new IllegalStateException(this.getStatusStringLocked());
+                failure = ExceptionUtil.combine(failure, new IllegalStateException(getStatusStringLocked()));
 
             if (failure != null)
                 abortResponse(failure);