Fixes #11679 - Jetty 12.0.8 seems to leak connection when it encounters earlyEOF. #11719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs earlyEOF. Changed HttpConnection.RequestHandler.earlyEOF() to produce EofException instead of BadMessageException, as it is more appropriate. Changed handling of HttpChannelState.onFailure() to not fail the write side unless there is a pending write callback. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
requested changes
Apr 29, 2024
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
requested changes
Apr 30, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
Show resolved
Hide resolved
| @@ -1057,7 +1057,7 @@ public void earlyEOF() | |||
| HttpStreamOverHTTP1 stream = _stream.get(); | |||
| if (stream != null) | |||
| { | |||
| BadMessageException bad = new BadMessageException("Early EOF"); | |||
| EofException bad = new EofException("Early EOF"); | |||
There was a problem hiding this comment.
I don't like that this sends a 500. I accept that perhaps the request is not bad and it is a connection problem, but it is certainly not a server problem as the 500 suggests.
How about:
Suggested change
| EofException bad = new EofException("Early EOF"); | |
| BadMessageException bad = new BadMessageException(null, new EofException("Early EOF")); |
There was a problem hiding this comment.
I think it should be a type of EOF exception because that's what it is.
I have introduced an HttpEofException so it is converted to a 400, but it is-a IOException, and it's quiet because it's a client close, so won't clutter the logs.
…tion. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
requested changes
May 2, 2024
…tation. Now failures only impact pending writes, so that it would be possible to write an HTTP error response. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
previously approved these changes
May 3, 2024
| @@ -1057,7 +1057,7 @@ public void earlyEOF() | |||
| HttpStreamOverHTTP1 stream = _stream.get(); | |||
| if (stream != null) | |||
| { | |||
| BadMessageException bad = new BadMessageException("Early EOF"); | |||
| HttpEofException bad = new HttpEofException("Early EOF"); | |||
There was a problem hiding this comment.
Either hardcode the "Early EOF" message in the exception's getReason() method, or return the message passed to the constructor, but let's not mix both.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed HttpConnection.RequestHandler.earlyEOF() to produce EofException instead of BadMessageException, as it is more appropriate.
Changed handling of HttpChannelState.onFailure() to not fail the write side unless there is a pending write callback.