Implemented servlet 6.1 redirect with content #11743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option for server to generate a short html redirect body content, as per RFC9110 (default false) Allowed an aggregated servlet response content to be used if clear is false.
janbartel
requested changes
May 3, 2024
joakime
reviewed
May 3, 2024
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/Dispatcher.java
Show resolved
Hide resolved
This style of extensibility (calling virtuals from constructors) is very fragile.
janbartel
requested changes
May 4, 2024
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Show resolved
Hide resolved
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Show resolved
Hide resolved
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Show resolved
Hide resolved
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Show resolved
Hide resolved
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Show resolved
Hide resolved
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Show resolved
Hide resolved
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Show resolved
Hide resolved
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Show resolved
Hide resolved
Also update EE10 to also noop included response methods
Also update EE10 to also noop included response methods
Also update EE10 to also noop included response methods
|
@sbordet @janbartel @lachlan-roberts nudge! |
janbartel
approved these changes
May 6, 2024
...ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiResponse.java
Outdated
Show resolved
Hide resolved
|
The CI failure is due to the EE1 JSP artifact not being released yet. Builds locally OK. |
…ee11/servlet/ServletApiResponse.java Co-authored-by: Jan Bartel <janb@webtide.com>
I went ahead and released 11.0.0-M19 of the mortbay jsp-impl jars. |
joakime
previously requested changes
May 6, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpStatus.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
Show resolved
Hide resolved
sbordet
requested changes
May 8, 2024
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpStatus.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
yes sorry. We have not been reviewing 12.1 changes unless necessary. I thought the redirect changes needed review, but some other servlet 6.1 changes got swept up.
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
Show resolved
Hide resolved
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/PushBuilderImpl.java
Outdated
Show resolved
Hide resolved
...-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiRequest.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
May 12, 2024
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpStatus.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpStatus.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ConnectionMetaData.java
Show resolved
Hide resolved
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/PushBuilderImpl.java
Outdated
Show resolved
Hide resolved
...-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiRequest.java
Outdated
Show resolved
Hide resolved
|
@sbordet nudge |
sbordet
requested changes
May 17, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
Outdated
Show resolved
Hide resolved
…/Response.java Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option for server to generate a short html redirect body content, as per RFC9110 (default false) Allowed an aggregated servlet response content to be used if clear is false.