Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11760 fix NPE getRequestURL() for cross context #11770

Merged
merged 4 commits into from
May 10, 2024
Merged

Issue #11760 fix NPE getRequestURL() for cross context #11770

merged 4 commits into from
May 10, 2024

Conversation

janbartel
Copy link
Contributor

Closes #11760

@janbartel janbartel added the Bug For general bugs on Jetty side label May 9, 2024
@janbartel janbartel requested review from gregw and joakime May 9, 2024 00:03
@janbartel janbartel self-assigned this May 9, 2024
@janbartel janbartel mentioned this pull request May 9, 2024
Closed
joakime
joakime previously approved these changes May 9, 2024
View reviewed changes
joakime
joakime approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I even added a Filter based test to see if that nuance could impact things.

@janbartel janbartel merged commit 0346b06 into jetty-12.0.x May 10, 2024
10 checks passed
@janbartel janbartel deleted the jetty-12.0.x-11760-request-url-cross-context branch May 10, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@gregw gregw Awaiting requested review from gregw

Assignees

@janbartel janbartel

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.10 (FROZEN)
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request.getHttpURI().getScheme() is null on FORWARD dispatched request, causing NPE
2 participants
@janbartel @joakime