build: switch to using typescript #3
Conversation
|
This would make the building and packaging much easier if we wanted to go that way! |
| import type {AggregatedResult, TestResult} from '@jest/test-result'; | ||
|
|
||
| import {DefaultReporter} from "@jest/reporters"; | ||
| import {LogEntry, LogType} from "@jest/console/build/types"; |
There was a problem hiding this comment.
reaching into build is not supported, if tsc supports package exports it'll actually fail from Jest 27.
I'd be happy to merge a PR in Jest that exports the types you need to build this reporter in TS
There was a problem hiding this comment.
Oh that is good to know! I'll add it to my list of things to do today. Thanks!
|
@yharaskrik thanks for this effort! To make this easier to review, could you Regarding development workflow, instead of Nx as discussed in #2, I'd favor |
|
Oh ya for sure! I did add dist to the git ignore but I must have added the folder to hit by accident prior. I'll take a look at tsdx! |
yharaskrik
force-pushed
the
jaybell/typescript-migration
branch
from
ed8f50c
to
e7070ac
Compare
|
Hey @jevakallio just letting you know that the type exports were merged into Jest master by @SimenB. Just gotta wait for those to land so that I can update this PR and then I think that is the last thing that needs to be done to get the TS migration done to have initial TS support! |
|
That change will only be available in Jest@27, so not sure you need to wait for it? As long as |
|
Oh sweet ok! Good to know, @jevakallio how do you feel about getting this in at some point then, we can roll with it for the time being and then I just need to update the type imports in a couple of places come jest 27. |
yharaskrik
changed the title
Initial implementation of TS, never really setup a TS repo other than an Nx workspace before. I have all the files switched to typescript and the tsc build setup but will still need to work on out it is being compiled so it is packageable by npm