Remove trailing slash except for '/' mountpoints #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 30ef9f3 set mp incorrectly for root mountpoints, causing mp to be set to '' instead of '/'. Switch to using readlink, which is more robust than using string manipulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
btrfs-snap is currently broken when used against root filesystems. For example, invoking
.../btrfs-snap -r / daily 3results in the following message:This broke in commit 30ef9f3, which set
mpincorrectly for root mountpoints, causingmpto be set to''instead of'/'. Switching to usingreadlinkto fix this, which is more robust than using string manipulation.