prevent exit code 1 when deleting a snapshot in quiet mode (-q) #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in quiet mode (i.e.,
-q
is given) false negative exit codes might occur.For example, when snapshots have to be deleted due to rotation.
This is especially annoying with (various) cron (implementations), because non-zero exit codes trigger an email being sent although no actual error occurred.
The cause might be the line
test -z "$quiet" && echo "$1"
infunction log.info()
(e.g., in 1.7.3:btrfs-snap/btrfs-snap
Lines 183 to 186 in 7126515
test
.