Fix asserting a throw in a catch block #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wraps the `throw` call on the generator to catch any errors that might get thrown in a catch block. Now `expectSaga` can assert on errors thrown in the saga's catch blocks. Fixes #296
|
Build is failing due to an issue with Yarn on Node 4 and 5: yarnpkg/yarn#6619 Same issue appears on the master build. |
|
@Mcat12 This is great. I am merging now. Thanks for your pull request. |
|
@jp928 When do you plan on releasing this fix? |
|
@Mcat12 I will release it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps the
throwcall on the generator to catch any errors that might get thrown in a catch block. NowexpectSagacan assert on errors thrown in the saga's catch blocks.Fixes #296