Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to truncate item labels and compute contrast item label color #225

Merged

Conversation

Yuri-Blankenstein-TNO
Copy link

I've added an option to clip labels when rendered inside a bar, see XYBarRenderer. Different clip options are available, see ItemLabelClip.
I also added an option to compute the item label color based on the item color, to automatically use a contrasting color.

@jfree
Copy link
Owner

jfree commented Jun 17, 2021

This looks like nice work, so sorry for taking a while to respond. I'm going to give this a try as soon as possible.

@Yuri-Blankenstein-TNO
Copy link
Author

I'm so glad that you like this work. I really hope that you are willing to merge my merge request, such that we can use JFreeChart as a base for Eclipse TRACE4CPS.

Please note that I have requested a couple of merge requests and some of them have minor conflicts with each other as they modify the same code. I also have an integration branch that contains all merge requests, see https://github.com/Yuri-Blankenstein-TNO/jfreechart/tree/release/eclipse-orbit

@Yuri-Blankenstein-TNO
Copy link
Author

David, I hope that you are ok and my apologies for trying to contact you in this way, but I do not see any alternative.
Do you think you will have time in the near future to consider to integrate my patches. Currently I'm finalizing the initial contribution for Eclipse LSAT and I would like to know if I will be able to integrate it with the official version of JFreeChart or if I need to think about releasing my fork to Eclipse Orbit.
I hope to hear from you soon.

@jfree jfree merged commit fae1314 into jfree:v1.5.x Oct 16, 2021
@jfree
Copy link
Owner

jfree commented Oct 16, 2021

Hi Yuri, thanks for the contribution! I've merged this one for the upcoming 1.5.4 release.

jfree added a commit that referenced this pull request Oct 16, 2021
@Yuri-Blankenstein-TNO Yuri-Blankenstein-TNO deleted the feature/renderer_colors_and_labels branch November 5, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants