Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowInsecureProtocol flag for http-configured Artifactory Repositories on Gradle #668

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kouta-kun
Copy link

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Hi! My current enterprise still has an HTTP Artifactory which I was not able to push to using the latest version, so I added the feature as a pass-through to the configured Gradle Repository. I was not able to get the tests working as I got a "Task with path 'pluginUnderTestMetadata' not found in project ':build-info-extractor-gradle'.", if anyone knows what that's about I'm okay with fixing it.

@github-actions
Copy link

github-actions bot commented Sep 23, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kouta-kun
Copy link
Author

recheck

@kouta-kun
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@eyalbe4 eyalbe4 self-requested a review September 23, 2022 23:12
@yahavi yahavi self-requested a review December 4, 2022 14:19
@yahavi
Copy link
Member

yahavi commented Dec 5, 2022

Thanks for this contribution, @kouta-kun!
Due to the complexity and issues of upgrading to Gradle 7, would you mind keeping just the core changes of this PR of adding the allowInsecureProtocol flag? That way we can review and add this feature quickly.

@eyalbe4 eyalbe4 removed their request for review December 19, 2022 12:10
@yahavi yahavi removed their request for review February 13, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants