Telling types of violations one from another #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iwankgb LGTM 👍 |
|
@jgautheron not quite yet, I need to work out some integration issues between |
iwankgb
force-pushed
the
pass_node_information_with_violation
branch
from
fcec674
to
66b9063
Compare
|
@jgautheron I sort of reimplemented it... Now it's much smaller and affects only what strings are not added to |
|
I would also appreciate if you released another version after merging this PR 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background information is available in golangci/golangci-lint#1500.
What I'm trying to achieve here is to have:
types being passed back to program callinggoconst.Run()It useful for us in
golangci-lintto start using upstream version ofgoconstinstead of outdated fork that we have been relying on for a while.Fixes #11.