Build up stargazer timeseries beyond 40k gazers using periodic snapshots #78
Conversation
|
Thank you for working on this, excited to see it merged! |
Expectation: does not fail analyze.py if file does not exist.
This is quite powerful, so this CSV file in the repo might be of decent use for external applications: - one data point per day at most - surpasses the 40k limit
The test data file I have added here has a date point that is early compared to stars-raw.csv which should be ignored. I manually inspected the resulting report.html, it shows the 2023;1000 data point in the plot.
I did this to see if resampling works well, found a tiny issue -- see next commit
Make it so that the right-most data point never goes into the future even if the resample interval gets large. The resample interval in the test suite is ~240 hours, and it became a little more than a cosmetic problem: it looked like inventing a data point from the (near) future :).
| --views-clones-aggregate-inpath tests/data/A/views_clones_aggregate.csv \ | ||
| --fork-ts-inpath=tests/data/A/forks.csv \ | ||
| --stargazer-ts-inpath=tests/data/A/stars.csv \ | ||
| --stargazer-ts-snapshot-inpath=tests/data/A/stars-snapshots.csv |
There was a problem hiding this comment.
That cmdline arg is the decisive addition in this test.
jgehrcke
changed the title
Thank you for the encouragement @Torantulino; it sometimes helps in the open-source world. My plan is to merge something still today to get some further testing done (I have pipelines set up that run this action from its main branch. I hope not too many others have that :)). Will then do a little more maintenance work, potentially do a little more thinking. Then I will invite you to test this out from the main branch, and then if things look good I will make a new release. Screenshot from local testing (synthetic data):
|
|
Such a 'tiny feature', so much code. Well well. State management as always is complex, but I start to feel good about this. Tested this in action with (note the I think this has worked as expected.
@ntindle @Torantulino @Swiftyos if you want to help testing this before release then please switch to |
|
I'll let the team know! |
|
Thank you, I've deployed it to our repo now. |
WIP for #76.