Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3510 #3516

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Fixes #3510 #3516

merged 3 commits into from
Apr 28, 2022

Conversation

atilafb
Copy link
Contributor

@atilafb atilafb commented Apr 28, 2022

This is a bugfix | documentation fix.

This PR fixes #3510

Proposed solution

This PR solves sidebar overlapping on documentation at hero section

Tradeoffs

Testing Done

Before:
Screenshot from 2022-04-28 11-37-38

After:
Screenshot from 2022-04-28 11-53-27

Changelog updated?

No.

@jgthms
Copy link
Owner

jgthms commented Apr 28, 2022

Thanks for this but can you change the .scss file instead? Otherwise, it will be overwritten next time the docs CSS is built.

The file to change is docs/_sass/pages/docs.scss and then in docs/ run npm run deploy.

@atilafb
Copy link
Contributor Author

atilafb commented Apr 28, 2022

Thanks for this but can you change the .scss file instead? Otherwise, it will be overwritten next time the docs CSS is built.

The file to change is docs/_sass/pages/docs.scss and then in docs/ run npm run deploy.

Of course, already update the .scss file.

@jgthms jgthms merged commit cb2666d into jgthms:master Apr 28, 2022
@jgthms
Copy link
Owner

jgthms commented Apr 28, 2022

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The navbar overlaps with sidebars in "Fullheight hero with navbar"
2 participants