Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color.sass | Adding $custom-shades compiles to broken css #3620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndreasMietk
Copy link

This is about Bulma.

Overview of the problem

Adding a custom shade via $custom-shades results in a broken css class

This is about the Bulma CSS framework
I'm using Bulma version [0.9.4]
This is a Sass issue: I'm using version [1.56.1]
I am sure this issue is not a duplicate

Description

Steps to Reproduce

  1. add $custom-sahdes to bulma.scss
    • image
  2. see in functions.sass
    • image
  3. see in color.sass
    • image
  4. see inbrowser
    • image

Expected behavior

This code in color.sass

@each $name, $shade in $shades
  .has-text-#{$name}
    color: $shade !important
  .has-background-#{$name}
    background-color: $shade !important

Should handle the created map values atleast with:

@each $name, $shade in $shades
  $value: $shade
  @if type-of($custom-colors) == 'map'
   $value: nth($shade, 1)
  @debug $value
  .has-text-#{$name}
    color: $value !important
  .has-background-#{$name}
    background-color: $value !important

Actual behavior

it takes the map as value for $shade

@AndreasMietk
Copy link
Author

is PR for this issue #3619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant