Added is-fullheight-with-spaced-navbar modifier for navbars that use is-spaced.

[rayment]

This is an improvement.

Proposed solution

Currently the hero layout with is-fullheight-with-navbar fails to account for is-spaced navbars resulting in an extra space at the bottom of the page. This PR adds a new modifier is-fullheight-with-spaced-navbar so that the spacing is accounted for on desktop and higher.

This problem has already been addressed in issue #2845 which in turn ended up going stale.

Tradeoffs

Users must now decide between is-fullheight-with-navbar and is-fullheight-with-spaced-navbar but we already differentiate between fixed-bars and regular bars so I don't see this as an unnecessary complication.

Testing Done

Minimal example:

<nav class="navbar is-light is-spaced" role="navigation">
  <div class="navbar-brand">
  </div>
</nav>
<section class="hero is-info is-fullheight-with-spaced-navbar">
  <div class="hero-body">
  </div>
</section>

Note how the page does not scroll when with-spaced-navbar is used.

Changelog updated?

No.

[rayment]

@jgthms ping?