Update navbar docs #3629
Open
Update navbar docs #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for browser accessibility support the hamburger menu should be a button. An anchor is for navigation, a button is for an action like a toggle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a documentation fix.
for browser accessibility support the hamburger menu should be a button. An anchor is for navigation, a button is for an action like a toggle. Semantic HTML should be used whenever possible.
Proposed solution
Currently the hamburger menu shows an anchor tag for the button which does not allow for it to be focusable out of the box. It should be a button tag because it's performing an action and not navigating the user to a new page.
You can read more about the difference between anchor tags and buttons here
Tradeoffs
Testing Done
None.
Changelog updated?
No.