Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3655 #3657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #3655 #3657

wants to merge 1 commit into from

Conversation

AadiRana911
Copy link

@AadiRana911 AadiRana911 commented Jun 21, 2023 •
edited

This is a bugfix.

Issue#3655 -> Update sass/components/navbar.sass:6
The variable $navbar-height is set to 3.25rem (52px) by default. However the navbar height changes to 3.5rem (56px) as soon as a button is added!

Proposed solution

Change default navbar height from 3.25rem to 3.5rem.

There is an alternate solution as well. We can reduce the default button size so that the navbar doesn't get disturbed

Testing Done

Unit testing has been done by linking my test project locally with bulma

I have:

  1. Cloned the bulma repo.
  2. Created a new react project named PGReact.
  3. Linked bulma locally with PGReact.
  4. Wrote this piece of code in App.js
    <body class="has-navbar-fixed-top">
      <nav class="navbar is-fixed-top has-background-light">
        <a class="navbar-item">Link</a>
        <div class="navbar-item">
          <a class="button">Button</a>
        </div>
      </nav>
    </body>
  1. Commented the code written between <nav> and </nav>
  2. The height of navbar didn't get disturbed

Changelog updated?

No.

@AadiRana911
Issue#3655 -> Update sass/components/navbar.sass:6
2150803 
The variable $navbar-height is set to 3.25rem (52px) by default.
However the navbar height changes to 3.5rem (56px) as soon as a button is added!

Fix Done: Change default navbar height from 3.25rem to 3.5rem.
@AaronErhardt AaronErhardt mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AadiRana911