Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parser option to parse raw content #304

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

jerjako
Copy link
Contributor

@jerjako jerjako commented Oct 9, 2023

Add an option to the parser to skip the auto-detect of the CTE. And return the content unchanged

@coveralls
Copy link

coveralls commented Oct 9, 2023

Coverage Status

coverage: 86.012% (+0.05%) from 85.966% when pulling 719aa73 on jerjako:feat/encode-options into 6241177 on jhillyerd:main.

@jerjako jerjako closed this Oct 9, 2023
@jerjako jerjako deleted the feat/encode-options branch October 9, 2023 16:37
@jerjako jerjako restored the feat/encode-options branch October 9, 2023 16:38
@jerjako jerjako reopened this Oct 9, 2023
@jerjako jerjako changed the title feat: add parser option to parse raw content Draft: feat: add parser option to parse raw content Oct 9, 2023

Verified

This commit was signed with the committer’s verified signature.
@jerjako jerjako force-pushed the feat/encode-options branch from 1c9b32c to 522ab2d Compare October 10, 2023 07:22
@jerjako jerjako changed the title Draft: feat: add parser option to parse raw content feat: add parser option to parse raw content Oct 10, 2023
@jhillyerd
Copy link
Owner

I'm in favor of this, but have two concerns:

  1. I don't like that a "Parser" option is changing the output of the encoder. Given we don't have a way to set encoding options, I think we can live with this for now.
  2. This change must add unit tests, otherwise it will be too easy to break in the future.

Verified

This commit was signed with the committer’s verified signature.
@jerjako
Copy link
Contributor Author

jerjako commented Oct 13, 2023

Thank you @jhillyerd
I know what you mean, I'm not a fan either. I've tested to change the behavior of the Encode function, but without luck.
I've added a simple test that will show the diff with and without the option.

Copy link
Owner

@jhillyerd jhillyerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small changes, thanks.

Verified

This commit was signed with the committer’s verified signature.
@jhillyerd jhillyerd merged commit 9d1f8fe into jhillyerd:main Oct 17, 2023
@jhillyerd
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants