use default link colors of Bootswatch theme #10102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishal423
requested changes
Jul 17, 2019
generators/client/templates/angular/src/main/webapp/content/scss/global.scss.ejs
Show resolved
Hide resolved
With c55634e, it was decided to override the link color of Bootstrap/the Bootswatch theme for passing the Lighthouse accessibility audit. I think this is a bad idea since 1. the picked color might not match the color scheme of the Bootswatch theme and 2. it should be the responsibility of the theme to consider accessibility concerns and not JHipster building on top of this. This commit only applies the link color when no Bootswatch theme is chosen. In this case, the Bootstrap default theme is used and Bootstrap recommends to 'manually modify/extend these default colors [e.g. the link color] to ensure adequate color contrast ratios': https://getbootstrap.com/docs/4.1/getting-started/accessibility/#color-contrast.
jack-kerouac
force-pushed
the
remove-custom-link-color
branch
from
efcbaaa
to
b9af784
Compare
vishal423
approved these changes
Jul 18, 2019
|
thanks @jack-kerouac |
jack-kerouac
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With c55634e, it was decided to override the link color and font-weight of Bootstrap/the Bootswatch theme for passing the Lighthouse accessibility audit.
I think this is a bad idea since 1. the picked color might not match the color scheme of the Bootswatch theme and 2. it should be the responsibility of the theme to consider accessibility concerns and not JHipster building on top of this. This also again reduces the JHipster provided CSS (which I think is in general a good idea).
I thus suggest to remove this custom overriding of the link colors again.