Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UAA support #13696

Merged
merged 25 commits into from
Jan 25, 2021
Merged

Remove UAA support #13696

merged 25 commits into from
Jan 25, 2021

Conversation

pascalgrimaud
Copy link
Member

Fix #13081

@pascalgrimaud
Azure Pipelines: remove uaa
b914960
@pascalgrimaud
Remove UAA link from Daily builds
9760d58
@pascalgrimaud
Remove UAA in CI scripts and samples
faa03d0
@pascalgrimaud
Remove UAA from test folder
86917d0
@pascalgrimaud
Fix lint when removing UAA
492d816
@pascalgrimaud
Fix tests
fa02b92
@pascalgrimaud
Remove UAA in server files
327bcc3
@pascalgrimaud
Remove UAA in prompts and index for server
c95c4ff
@pascalgrimaud
Remove UAA in Gradle properties and build
b41c2fb
@pascalgrimaud
Remove UAA in pom.xml for Maven
5419854
@pascalgrimaud
Remove UAA in docker-compose files
d1562d0
@pascalgrimaud
Remove UAA in java templates
9457980
@pascalgrimaud
Delete class files related to UAA
297ec0c
@pascalgrimaud
Remove class related to UAA and properties for Spring Boot
4461c70
@pascalgrimaud
Fix lint in server when removing UAA
871a9f4
@pascalgrimaud
Remove UAA in app sub generator
c102315
@pascalgrimaud
Remove UAA in some files in client sub gen
c2c92e4
@pascalgrimaud
Remove UAA in client sub gen
a0cc87e
@pascalgrimaud
Remove UAA in JDL
3d78415
@pascalgrimaud
Remove UAA in entities sub gen
5a377ca
@pascalgrimaud
Remove UAA in base code, generator and docker
f243246
@pascalgrimaud
Remove UAA in remaining files
320a74c
@pascalgrimaud
Fix lint in generator-base when removing UAA
5a53de7
@pascalgrimaud
Fix template in generated README
3c3eb5c
@pascalgrimaud pascalgrimaud changed the title Uaa remove support Remove UAA support Jan 23, 2021
@pascalgrimaud pascalgrimaud marked this pull request as ready for review January 23, 2021 20:19
mshima
mshima approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a missing condition removal and an empty line removal.

generators/server/templates/pom.xml.ejs Outdated Show resolved Hide resolved
generators/common/templates/README.md.ejs Outdated Show resolved Hide resolved
@pascalgrimaud
Copy link
Member Author

Thanks so much for the review @mshima !
I'll update this PR soon

@mshima
Copy link
Member

mshima commented Jan 24, 2021

Great work @pascalgrimaud

@pascalgrimaud
Copy link
Member Author

As approved by @mshima, I'm merging this, to avoid too much conflicts in incoming PR

@pascalgrimaud pascalgrimaud merged commit 96027c9 into jhipster:main Jan 25, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

UAA support: should it be removed ?
2 participants
@pascalgrimaud @mshima