Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue builds #15105

Merged
merged 1 commit into from May 25, 2021
Merged

Fix Vue builds #15105

merged 1 commit into from May 25, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented May 25, 2021

All Vue builds failed currently, with this error:

ERROR org.springframework.boot.SpringApplication - Application run failed java.lang.IllegalStateException: No subdirectories found for mandatory directory location 'file:./config/*/'.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member

mshima commented May 25, 2021

Upstream bug: spring-projects/spring-boot#26627

@qmonmert
Copy link
Contributor Author

spring-projects/spring-boot#26627

@mshima yes I saw that

@mshima
Copy link
Member

mshima commented May 25, 2021

Just for reference.

@mshima
Copy link
Member

mshima commented May 25, 2021

Those config files seems related to webpack.
What about move config/* to webpack/*.

@qmonmert
Copy link
Contributor Author

@mshima I try

@qmonmert
Copy link
Contributor Author

@mshima it works :)

@DanielFran
Copy link
Member

@qmonmert @mshima Better to revert the upgrade to spring-boot 2.4.6?

@qmonmert
Copy link
Contributor Author

@DanielFran it works with Angular

@mshima
Copy link
Member

mshima commented May 25, 2021

@qmonmert try renaming webpack/index.js to env.js.
Probably require('webpack') is conflicting.

@qmonmert qmonmert changed the title Fix Vue builds (temporarily) Fix Vue builds May 25, 2021
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qmonmert I believe the path is not correct for the files you are removing

generators/cleanup.js Show resolved Hide resolved
generators/cleanup.js Show resolved Hide resolved
generators/cleanup.js Show resolved Hide resolved
@DanielFran DanielFran merged commit 9932015 into jhipster:main May 25, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels May 28, 2021
@pascalgrimaud
Copy link
Member

Adding a bounty on this, for the time to investigate and fix the builds
Plz claim it, @qmonmert

@qmonmert
Copy link
Contributor Author

@pascalgrimaud
Copy link
Member

@qmonmert : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ pr: bug-fix theme: vue $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants