Gradle 4 upgrade

[atomfrede]

I fixed some problems with dependency resolution (see comment here: spring-projects/spring-boot#9516) and tested with following settings:

• SQL, Monolithic Application
• Gatling Tests
• Gateway
• Microservice
• Mongo
• Cassandra

I will update the PR when more tests are done,

• Travis tests are green
• Tests are added where necessary
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

close #5936

[atomfrede]

@jhipster/developers I have tested all above and couldn't find any problems, so I suggest we can merge it.

[atomfrede]

Furthermore when using gradle you can execute a single simulation with -Psimulation=YourSimulation

[jdubois]

Congrats!! As there is a lot of advertisement in conferences and Twitter about the new Gradle performance enhancements, did you experience any speed up?

[atomfrede]

Right that's what wanted to try with empty m2 repository as that was most annoying because dependencies have not been downloaded in parallel. Will post some numbers.

[pascalgrimaud]

@atomfrede :

• can you rebase with master plz?
• then, test with gradle+cassandra
• I think there is an issue, but it's not related to your PR...

Maybe the problem comes from this commit 635a757 and the springfox version 2.7.0

[atomfrede]

@pascalgrimaud You are right. It doesn't work. Get this error java.lang.NoClassDefFoundError: com/google/common/util/concurrent/FutureFallback

EDIT: Same problem on master

[pascalgrimaud]

yes, I saw it there : https://travis-ci.org/hipster-labs/jhipster-travis-build/branches
There is a branch with full builds for Gradle

Not perfected yet and a lot of random failures, specially with uaa, but there are more tests than our current Travis

[atomfrede]

Wow, cool. Will check it and try it locally.

[atomfrede]

I fixed the cassandra problem (missing guava dependency).
Some numbers regarding performance

• mvn clean package -DskipTests with empty .m2: ~2 Min
• ./gradlew clean bootRepackage with empty jar cache: ~1 Min
• mvn clean package -DskipTests with full .m2: ~15 sec
• ./gradlew clean bootRepackage with full jar cache: ~10 sec (with daemon), ~18 sec (without daemon)

I have no numbers currently for gradle 3.5 but the initial build with empty caches was terrible slow because of non parallel download of dependencies, so for me these are very cool results.

[jdubois]

OK, so nothing extraordinary here, but we need to upgrade anyway -> are you confident with merging your PR? If yes, let's do it!

[atomfrede]

Let's Merge it to see if any less used combination doesn't work well. As it also fixes gradle and Cassandra we should Merge it.

[deepu105]

Wow so finally now Gradle is faster than maven. @atomfrede what say we make Gradle the default option?
Most people these days use Gradle anyway

[deepu105]

@jdubois what say we make Gradle the default option?

[sendilkumarn]

I second it. 👍

[atomfrede]

@deepu105 Would like to have gradle as default, but I think maven is still the dominant build system. E.g. all our services are build with maven. We use gradle for custom things, like executing test with docker or setting up our local minikube environment or handling translations via crowdin. @jdubois How are the current stats maven vs gradle?

[pascalgrimaud]

I'm a maven user, so I'd prefer keeping maven as default :)
I'm curious to have some stats between maven and gradle too

[deepu105]

Stats will always swing towards what we set us default :) Thanks & Regards, Deepu

…

On Mon, Jul 3, 2017 at 8:50 AM, Pascal Grimaud ***@***.***> wrote: I'm a maven user, so I'd prefer keeping maven as default :) I'm curious to have some stats between maven and gradle too — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5949 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlFxlK-Lh6AgOeHofDSG97uIjn16-kks5sKI9IgaJpZM4N9xkM> .

[jdubois]

Yes stats are always misleading, but as you asked for them, for July 2017, we have:

• Maven 81,71 %
• Gradle 18,29 %

Now I don't want to change the build tools for the following reasons:

• Our current focus is Angular 4, and that's already too complex
• Gradle 4 just got merged this morning, we need time to see if everything works fine (Docker build? CI-CD?)
• All my customers (and me also!) use Maven
• I'm still totally confused when looking at the Gradle conf, after years trying to understand it, when I've never had any trouble with Maven

Then, I'm totally opened at migrating to Gradle in the future:

• When we have the guarantee everything works well with Gradle
• If the Grade build is much quicker (but when I mean quicker, I mean "without the Gradle daemon")
• If this allows us to create some advanced configuration, maybe with the Angular/Webpack builds for example, and that in the end we have something much easier/performant/dev-friendly

[atomfrede]

Totally agree with you, except I don't understand the maven config very well :) But ~20% for a non default option is quite good I think.

[oehme]

If the Grade build is much quicker (but when I mean quicker, I mean "without the Gradle daemon")

Gradle is designed to trade off the first startup for fast subsequent builds. The daemon is the default for that reason. Running without it only makes sense on throwaway CI machines like Travis. That being said, the only time I've seen Maven being quicker on a "cold" machine was either

• very small projects where Maven can keep the initial head start (that seems to be the case here)
• misconfigured Gradle builds

Using clean builds for performance comparisons is missing an important point though - Gradle developers will pretty much never call clean. Gradle has properly working incremental builds.

OK, so nothing extraordinary here

It's 50% faster than Maven for a clean build on a pretty simple project. That's pretty extraordinary, given that in such a small project, there is almost nothing to optimize ;)

I'm not going to advocate for or against changing the default, that should be decided based on your community's feedback. I just wanted to give some perspective on those numbers.

[deepu105]

Thanks for the clarification @oehme
From your profile looks like you are in the core Gradle team am I right? We would love to have your feedback on the Gradle build we create

[oehme]

Sure, if you point me to an example of a typical project you create, I'm happy to give some feedback.

[atomfrede]

@oehme I think best way is to test drive https://jhipster.julien-dubois.com/. I have created a simple monolithic application here: https://github.com/atomfrede/jhipsterGradleSampleApplication

If you find things to do better (I am sure you will) that would be awesome!

[deepu105]

Yes and there is also the official Gradle sample here https://github.com/jhipster/jhipster-sample-app-gradle which should be the same as @atomfrede posted above s it is generated with same version of JHipster

[jdubois]

@oehme oh yes, your feedback is very highly welcome here!!!! I can't guarantee we'll switch the default to Gradle, but if performance is much better (and maybe features also?), we'll do our best to market it, and maybe change the stats!

[oehme]

Just FYI, I'm on vacation next week, so I'll only get around to this in August. I think setting up a hangout would be ideal to walk through some of the pieces.

[deepu105]

Yes we could do that I guess

…

On 21 Jul 2017 3:03 pm, "Stefan Oehme" ***@***.***> wrote: Just FYI, I'm on vacation next week, so I'll only get around to this in August. I think setting up a hangout would be ideal to walk through some of the pieces. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5949 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlFxU1vbT-AE1cwoK-7QP6YpHT7Qc_ks5sQKG4gaJpZM4N9xkM> .

[atomfrede]

I am also on vacation next week so august would be fine.

[sendilkumarn]

Thanks a lot for the clarification @oehme
and ofcourse +1 for hangout.

[deepu105]

@oehme could you let us know a date in August when you would be available for the call you suggested so that I can send out an invitation based on that so that people dont forget :)

[oehme]

How about the 16th or 17th at 18:00 CEST/ 9:00 PST? From our side @eriwen and I would like to join in.

[atomfrede]

16th is not possible for me as we have jug meetup but no problem if everyone else prefers 16th.

[oehme]

@deepu105 Wednesday is now already taken for me, but the time slot on Thursday is still free. Can you send out an invite?

[deepu105]

@oehme yes I'll send an invite. Unfortunately, my 6PM Thursday is taken as well but if @atomfrede and @sendilkumarn are available that should be fine. Guys please confirm

[deepu105]

@jhipster/developers anyone else interested to join?

[jdubois]

I'd love to, but I'm still on holidays (with 3 small kids, so I wonder if that can be called holidays??)

[atomfrede]

I can make it.

[deepu105]

@atomfrede great. I'll send an invite

[deepu105]

I have send out a google calendar invite for 17th August 1800 CEST

[oehme]

@deepu105 There is no hangout attached to the calendar invite, can you please add one?

[atomfrede]

@deepu105 @oehme Should I create a new invite?

[deepu105]

@atomfrede @oehme @sendilkumarn sorry guys I didnt have access to laptop as I was traveling. Did you manage to make the Hangout? I guess I totally forgot to attach the link. damn me

[atomfrede]

I posted a summary to our mailing list :) 2017-08-17 21:20 GMT+02:00 Deepu K Sasidharan <notifications@github.com>:

…

@atomfrede <https://github.com/atomfrede> @oehme <https://github.com/oehme> @sendilkumarn <https://github.com/sendilkumarn> sorry guys I didnt have access to laptop as I was traveling. Did you manage to make the Hangout? I guess I totally forgot to attach the link. damn me — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5949 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMaicKukxLTKiEJCFL76_-36qjxJcJxks5sZJJ2gaJpZM4N9xkM> .

[deepu105]

Pasting the thread link for anybody interested https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/jhipster-dev/P91z4qd_-XY/m6qQTN8jAAAJ