-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Reactive support #7983
Initial Reactive support #7983
Conversation
@cbornet you have Travis work with Reactive??? |
Yes, I do 😄 ! |
as always, incredible work @cbornet ! 😮 |
I force pushed one last time because I had done a mistake in the last commit. I won't do it again, I promise. |
The last time i used webflux i found that Springfox is not willing at this time to support it. So i cannot use it to document my apis. |
I think Springfox's maintainer is working actively on supporting Webflux. It seems like a lot of work and I'm sure he would love to get help. Unfortunately I have so much to do right now that I can't help him myself. |
@cbornet @joumenharzli see springfox/springfox#2608 has been merged! :) |
Is there any objection to merge once I resolve the conflicts ? |
@cbornet no, because I don't think this would have any impact with the rest of the code, so there's no risk |
OK so I'll proceed. After that we can do more atomic PRs. |
@jdubois IMO this ticket needs more than a 100$ bounty, may be we should multiply bounty based on complexity of the ticket since not every ticket are the same |
Yes this is like the VueJS bug bounty. The "lead" of each project (so @cbornet here) should create a project and split the main issue into several issues. Then we'll add bounties to those tickets: like for VueJS, I think we should give at least $500 here, so that means 5 tickets will have each a $100 bounty. That's also better because maybe several people will work on the project, so that's a way to split the money between contributors. |
Ya that sounds fine
Thanks & Regards,
Deepu
…On Wed, Aug 29, 2018 at 11:31 AM Julien Dubois ***@***.***> wrote:
Yes this is like the VueJS bug bounty. The "lead" of each project (so
@cbornet <https://github.com/cbornet> here) should create a project
<https://github.com/jhipster/generator-jhipster/projects> and split the
main issue into several issues. Then we'll add bounties to those tickets:
like for VueJS, I think we should give at least $500 here, so that means 5
tickets will have each a $100 bounty.
That's also better because maybe several people will work on the project,
so that's a way to split the money between contributors.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7983 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDlF58CuniSwOg3vy-n8GtXT2qC38Ztks5uVl95gaJpZM4VRrJh>
.
|
added Reactive support webflux with jwt |
@Mahdihp that's the third comment you post in a row which doesn't make much sense, what's happening? |
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed
First basic implementation of reactive option.
The
experimental
flag must be set to see the option in the questions.See #7608