Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Reactive support #7983

Merged
merged 25 commits into from
Sep 5, 2018
Merged

Initial Reactive support #7983

merged 25 commits into from
Sep 5, 2018

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Jul 16, 2018

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

First basic implementation of reactive option.
The experimental flag must be set to see the option in the questions.

See #7608

@cbornet cbornet changed the title Reactive Initial Reactive support Jul 16, 2018
@jdubois
Copy link
Member

jdubois commented Jul 19, 2018

@cbornet you have Travis work with Reactive???

@cbornet
Copy link
Member Author

cbornet commented Jul 19, 2018

Yes, I do 😄 !
I'll be AFK for 3 weeks (at least) so it would be great if this could be reviewed and merged meanwhile. Or at least don't do any big bang refactoring during this period so it's not a nightmare to rebase 😅
Don't hesitate to fix directly on the branch if needed.

@pascalgrimaud
Copy link
Member

as always, incredible work @cbornet ! 😮

@cbornet
Copy link
Member Author

cbornet commented Jul 19, 2018

I force pushed one last time because I had done a mistake in the last commit. I won't do it again, I promise.

@joumenharzli
Copy link

The last time i used webflux i found that Springfox is not willing at this time to support it. So i cannot use it to document my apis.
springfox/springfox#1773 (comment)
What will you plan for Swagger ?

@cbornet
Copy link
Member Author

cbornet commented Aug 9, 2018

I think Springfox's maintainer is working actively on supporting Webflux. It seems like a lot of work and I'm sure he would love to get help. Unfortunately I have so much to do right now that I can't help him myself.
I guess we'll have to wait for now. But don't worry there's already plenty of work around Webflux for Jhipster.
As for the Api-first option, it shouldn't be hard to do in case you're also using it.

@DanielFran
Copy link
Member

@cbornet @joumenharzli see springfox/springfox#2608

@DanielFran
Copy link
Member

@cbornet @joumenharzli see springfox/springfox#2608 has been merged! :)

@cbornet
Copy link
Member Author

cbornet commented Aug 28, 2018

Is there any objection to merge once I resolve the conflicts ?

@jdubois
Copy link
Member

jdubois commented Aug 28, 2018

@cbornet no, because I don't think this would have any impact with the rest of the code, so there's no risk

@cbornet
Copy link
Member Author

cbornet commented Aug 28, 2018

OK so I'll proceed. After that we can do more atomic PRs.

@deepu105
Copy link
Member

@jdubois IMO this ticket needs more than a 100$ bounty, may be we should multiply bounty based on complexity of the ticket since not every ticket are the same

@jdubois
Copy link
Member

jdubois commented Aug 29, 2018

Yes this is like the VueJS bug bounty. The "lead" of each project (so @cbornet here) should create a project and split the main issue into several issues. Then we'll add bounties to those tickets: like for VueJS, I think we should give at least $500 here, so that means 5 tickets will have each a $100 bounty.

That's also better because maybe several people will work on the project, so that's a way to split the money between contributors.

@deepu105
Copy link
Member

deepu105 commented Aug 29, 2018 via email

@cbornet cbornet merged commit ed3045e into master Sep 5, 2018
@cbornet cbornet deleted the reactive branch September 5, 2018 09:12
@jdubois jdubois added this to the 5.3.1 milestone Sep 5, 2018
@Mahdihp
Copy link

Mahdihp commented Dec 5, 2018

added Reactive support webflux with jwt

@jdubois
Copy link
Member

jdubois commented Dec 5, 2018

@Mahdihp that's the third comment you post in a row which doesn't make much sense, what's happening?

@murdos murdos added the theme: reactive ⚛️ Spring WebFlux label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants