Add identifer to NotificationResponse.payload so alice's notification can be filtered in notification listener. #170
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a string to NotificationResponse.payload that sent to the apps that utilize alice package. This string is useful when we have our own onTapped/onClicked listener for the foreground notification.
You can see the complete issue here.
I propose this implementation so that later I can implement this filtering inside my foreground notification listener.
At first I just want to filter the alice notification by using
if (payload.payload.isEmpty && !kReleaseMode)
since alice sent an empty string to NotificationResponse.payload. However, later I think that it's a bad idea to do so, since other native may also sent an empty string as payload.