Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Android SurfaceView #1046

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FlutterSu
Copy link
Contributor

@FlutterSu FlutterSu commented Jun 28, 2022

Features: replace Android SurfaceTextureEntry to SurfaceView

Profit

  • video not skipped frames on AndroidTV
  • best for Android WideVine

Block problem

@FlutterSu FlutterSu force-pushed the feature/android_surfaceview branch from f1fd973 to b100ef0 Compare June 28, 2022 12:19
@andreyneto
Copy link

andreyneto commented Jul 1, 2022

Hi @FlutterSu! I'm tryin to test your feature but i'm getting the following error when running the example app

PlatformException(VideoError, Video player had error com.google.android.exoplayer2.ExoPlaybackException: Source error, , null)

Any hints? I need to do something else to get this working?

@FlutterSu
Copy link
Contributor Author

Hi @FlutterSu! I'm tryin to test your feature but i'm getting the following error when running the example app

PlatformException(VideoError, Video player had error com.google.android.exoplayer2.ExoPlaybackException: Source error, , null)

Any hints? I need to do something else to get this working?

Hi!
Nothing is needed.

Are you running the better_player example?

Can you provide more detail?

@andreyneto
Copy link

the error occurs in the DRM page from the better_player example, but in my app with my own drm implementation is running fine. Thanks for the work.

@artem-2024
Copy link

Hi! I get a issue when release mode

Platform view hasn't been initialized from the platform view channel.

@mis-kcn
Copy link

mis-kcn commented Aug 8, 2022

Hello @FlutterSu would you be able to look at this feature request? #1066 I was just wondering if it would possible to render the SubtitleView alongside the Surface renderer, or something similar. Thanks!

Gaurav192 pushed a commit to Gaurav192/betterplayer that referenced this pull request Oct 29, 2022
@rounce
Copy link

rounce commented Jan 24, 2023

Unfortunately, this feature somehow breaks the return from fullscreen: the screen goes black.

@TDUser91
Copy link

TDUser91 commented Nov 8, 2023

Hello @FlutterSu would you be able to look at this feature request? #1066 I was just wondering if it would possible to render the SubtitleView alongside the Surface renderer, or something similar. Thanks!

SurfaceView is strictly a consumer and Surface is strictly a producer.

SurfaceView's Surface is the producing side of a producer/consumer pair, with the consumer side being the display. You can't use SurfaceView as the source of a stream as a result, so the entire concept of connecting a SurfaceView to a video encoder doesn't work. Both of those consume frames and neither of them produce frames.

Read more : https://source.android.com/docs/core/graphics/architecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants