Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔄 Synced file(s) with jhudsl/AnVIL_Template #11

Merged
merged 20 commits into from Sep 8, 2022

Conversation

jhudsl-robot
Copy link
Contributor

Synced local file(s) with jhudsl/AnVIL_Template.

Changed files
  • Synced local directory .github/workflows/ with remote directory .github/workflows/
  • Synced local scripts/spell-check.R with remote scripts/spell-check.R
  • Synced local scripts/url-check.R with remote scripts/url-check.R
  • Created local scripts/quiz-check.R from remote scripts/quiz-check.R
  • Synced local directory style-sets with remote directory style-sets
  • Created local directory assets/box_images/ and copied all sub files/folders from remote directory assets/box_images/
  • Synced local directory assets/AnVIL_style/ with remote directory assets/AnVIL_style/
  • Created local directory assets/GDSCN_style/ and copied all sub files/folders from remote directory assets/GDSCN_style/
  • Synced local scripts/anvil_repo_check.R with remote scripts/anvil_repo_check.R
  • Synced local scripts/anvil_repo_table.R with remote scripts/anvil_repo_table.R

This PR was created automatically by the repo-file-sync-action workflow run #2974015337

@KatherineCox
Copy link
Contributor

KatherineCox commented Sep 1, 2022

@avahoffman any idea what's going wrong here? this is breaking before it even gets to rendering

Edit: seeing the same error here: jhudsl/GDSCN_Book_Statistics_for_Genomics_Differential_Expression#20

@avahoffman
Copy link
Contributor

Looks like it might be a security issue? I made a workaround that follows this issue:
This looks similar to the issue here.

Created an issue in OTTR main.. let's keep an eye on it? jhudsl/OTTR_Template#561

I created a fix here: #13 but looks like there's something else going on too. Feel free to merge the fix if you want!

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Re-rendered previews from the latest commit:

Updated at 2022-09-08 with changes from 3d7bb23

@KatherineCox
Copy link
Contributor

KatherineCox commented Sep 8, 2022

@avahoffman I think I've got the style stuff all taken care of. Are the workflows/scripts okay to be merged into main?

@avahoffman
Copy link
Contributor

@KatherineCox go for it!

@KatherineCox KatherineCox merged commit 2295f62 into main Sep 8, 2022
@KatherineCox KatherineCox deleted the repo-sync/AnVIL_Template/default branch September 8, 2022 22:06
@KatherineCox KatherineCox restored the repo-sync/AnVIL_Template/default branch September 8, 2022 22:19
@KatherineCox
Copy link
Contributor

@avahoffman this was rendering fine in the PR, but when it got merged into main I'm seeing the same "can only be used inside a git repository error"
https://github.com/jhudsl/GDSCN_Book_Statistics_for_Genomics_scRNA-seq/runs/8259733991?check_suite_focus=true

@KatherineCox
Copy link
Contributor

KatherineCox commented Sep 8, 2022

also I applied your fix to jhudsl/GDSCN_Book_Statistics_for_Genomics_Differential_Expression#20 and it successfully solved the error in the PR render there. I'm guessing it'll break if I try to merge it into main.

@avahoffman
Copy link
Contributor

I imagine git config --global --add safe.directory "$GITHUB_WORKSPACE" needs to be added to ro the render-all workflow as well. Let me go ahead and put a patch in, and see if it helps.

@KatherineCox KatherineCox deleted the repo-sync/AnVIL_Template/default branch September 13, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants