Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Type Tests to use Vitest #1199

Open
wants to merge 5 commits into
base: yarn-berry
Choose a base branch
from
Open

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Feb 9, 2023

This PR builds on top of #1198, please merge that first

This PR's overarching goal was to replace dts-lint with Vitest for Type Testing, as dts-lint is deprecated now.

However, to accomplish this goal cleanly, I had to:

  • Updated how GitHub actions calls type tests
  • Made lerna call test:ts for all packages with the script name, not just the two hardcoded packages
  • Add a shared TypeScript configuration in a new @jimp/config internal package (to add in missing tsconfig.json files without duplicating contents. I plan on expanding this internal package for ESLint, test configs, and more later on)
  • Add missing @jimp/core dev dependency for all plugin packages (to avoid any typings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant