avoid relying on __dirname global constant #1237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
requested changes
May 20, 2023
| import bMFont from "load-bmfont"; | ||
| import { isNodePattern, throwError } from "@jimp/utils"; | ||
| import { measureText, measureTextHeight, splitLines } from "./measure-text"; | ||
|
|
||
| const __filename = url.fileURLToPath(import.meta.url); |
There was a problem hiding this comment.
Does all compiled output have the correct code here?
ex:
- cjs
- esm
- browser
Once verified will merge
There was a problem hiding this comment.
let me check.
I can say for sure that esm is working.
the other two I have to check. any direction on how to do it correctly would be appreciated
Thanks!
|
Hey hey @Javier-Rotelli @hipstersmoothie, any plan to get this merged ? 👀 It's really blocking when using Vite… |
|
We would have to make sure it works for all envs, not just modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1235
What's Changing and Why
Removed usage of global variable
__dirnameto avoid errors when bundling with rollupWhat else might be affected
Tasks
jimp.d.ts