Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack config to output UMD library #1255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fuchstim
Copy link

What's Changing and Why

This addresses an issue when importing Jimp in a browser environment (detailed issue with workarounds here: #1194):

import Jimp from 'jimp';
// Jimp = {}

const Jimp = require('jimp');
// Jimp = {}

// Workaround:
import type TJimp from 'jimp';
import 'jimp';

const { Jimp } = window as unknown as { Jimp: typeof TJimp };

The proposed fix correctly configures webpack to emit a library export, which both fixes the issue above as well as maintains compatibility with current import methods (and workarounds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant