Improve color operations performance #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted to bitwise operators to improve performance at high volumes.
Converted math to bitwise operators to improve performance at high volumes.
Moved any repetitive mathematical operations outside the core loop and simplified accessors to allow for maximum JIT compile optimizations to take place.
Remove redundant calls to Math.round as it is called again within getPixelIndex in both cases.
… number Added operation to ensure 32-bit color output is interpreted as a positive integer.
Final operation can "re-negate" the value - moved the conversion to unsigned int to be after alpha integration into the value.
Also issues with high-bit values going from int to RGBA - fixed.
hipstersmoothie
approved these changes
Feb 23, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
Some functions have operations within loops that don't need to be and/or use floating point math where bitwise operators are faster. Performance is impacted when doing intense operations on large images.
What else might be affected
Nothing. The logic is exactly equivalent.
Tasks
None required - changes are entirely internal.